From 7b624b3238274d4696c3f507a9309fe5925f8e16 Mon Sep 17 00:00:00 2001
From: James Wampler <james@wamp.dev>
Date: Thu, 16 Apr 2026 08:59:54 -0700
Subject: [PATCH] Fixing segment create error, adding environment to feature
 dialog

---
 .vscode/settings.json                            |  15 +++++++++++++++
 docs/.08_testing_strategy.md.kate-swp            | Bin 1440 -> 0 bytes
 .../src/components/features/FeatureDetail.vue    |   3 ++-
 .../src/components/segments/RuleGroupEditor.vue  |   6 +++---
 .../src/components/segments/SegmentEditor.vue    |   2 +-
 src/admin/src/types/api.ts                       |   2 +-
 .../components/segments/SegmentEditor.spec.ts    |   2 +-
 src/admin/tests/unit/views/SegmentsView.spec.ts  |   2 +-
 8 files changed, 24 insertions(+), 8 deletions(-)
 create mode 100644 .vscode/settings.json
 delete mode 100644 docs/.08_testing_strategy.md.kate-swp

diff --git a/.vscode/settings.json b/.vscode/settings.json
new file mode 100644
index 0000000..91b69b2
--- /dev/null
+++ b/.vscode/settings.json
@@ -0,0 +1,15 @@
+{
+    "sqltools.connections": [
+        {
+            "ssh": "Disabled",
+            "previewLimit": 50,
+            "server": "mic-check-db-1",
+            "port": 5432,
+            "askForPassword": true,
+            "driver": "PostgreSQL",
+            "name": "MicCheck - local",
+            "database": "micheck",
+            "username": "micheck"
+        }
+    ]
+}
\ No newline at end of file
diff --git a/docs/.08_testing_strategy.md.kate-swp b/docs/.08_testing_strategy.md.kate-swp
deleted file mode 100644
index 553524fe5987b9ad26ee0a6f387ed78b746f3f8b..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 1440
zcma*nNlqI<6vpxP6$l6Lk|f{|rT~F3wi7di!66JH0RtvDOlFXPEf-*$9cMsF6lKFf
zSaJX)Zb1DbTHmKyAQrv&`Ms+5>UFh~BxxA099Q$@lS(~btnF0uZH3k(Ng8KwF7E%`
zEnQ!hZm0hKdeL;XdOlyC4UvKHG==9+$&gFaa^{!e_uQ%c3Lnd_@uA#|D{>27mkZJQ
zH#o02?fUw+cu(=RD8C)o6z_=gJF)fKg{#Vchpqo^ys3B(4(G{+g?mNPdqj5Y*5c=G
zo(;Q~Vm7Sz*qZIbHmrVZ&3?f9s?Xc?!wupN#fNa%FFPC_76$`|lnuT5|J5bMhlx+h
zBiLTeD7Mq3ctrU{yd{6ccKT1zdZw1!R{j_smB;a#Jb|s=B(`aN#&*@Fuw9*LZ2in&
z`!txM=a;d)tuNR<jX7-fzTyq_JCE({ECeqqy!;r>E>G-l#I4+SY~@z)nf6=7)@}u-
zim&0KydLFmU~9jMZCsnUuJu2n_!hSQYS{Ms8Rc(dyG}dUuG?;uzlV=he;*g*I=1s4
ZJUaV04uiw;C-_@Y7KeY8ESbFz(g#;HtjhoZ

diff --git a/src/admin/src/components/features/FeatureDetail.vue b/src/admin/src/components/features/FeatureDetail.vue
index 8a95687..2e40282 100644
--- a/src/admin/src/components/features/FeatureDetail.vue
+++ b/src/admin/src/components/features/FeatureDetail.vue
@@ -54,7 +54,8 @@
                 <div>
                   <p class="text-body-1 font-weight-medium mb-1">Enabled</p>
                   <p class="text-body-2 text-medium-emphasis">
-                    {{ featureState.enabled ? 'On in this environment' : 'Off in this environment' }}
+                    {{ featureState.enabled ? 'On' : 'Off' }} in
+                    <strong>{{ contextStore.currentEnvironment?.name }}</strong>
                   </p>
                 </div>
                 <v-switch
diff --git a/src/admin/src/components/segments/RuleGroupEditor.vue b/src/admin/src/components/segments/RuleGroupEditor.vue
index f0db37e..cce58df 100644
--- a/src/admin/src/components/segments/RuleGroupEditor.vue
+++ b/src/admin/src/components/segments/RuleGroupEditor.vue
@@ -12,8 +12,8 @@
         data-testid="rule-type-toggle"
         @update:model-value="onTypeChange"
       >
-        <v-btn value="AND" size="small" data-testid="rule-type-and">ALL (AND)</v-btn>
-        <v-btn value="OR" size="small" data-testid="rule-type-or">ANY (OR)</v-btn>
+        <v-btn value="All" size="small" data-testid="rule-type-and">ALL (AND)</v-btn>
+        <v-btn value="Any" size="small" data-testid="rule-type-or">ANY (OR)</v-btn>
       </v-btn-toggle>
       <v-spacer />
       <v-btn
@@ -113,7 +113,7 @@ function onAddCondition(): void {
 }
 
 function onAddChildGroup(): void {
-  const newGroup: SegmentRule = { type: 'AND', conditions: [] };
+  const newGroup: SegmentRule = { type: 'All', conditions: [] };
   const childRules = [...(props.rule.childRules ?? []), newGroup];
   emit('update:rule', { ...props.rule, childRules });
 }
diff --git a/src/admin/src/components/segments/SegmentEditor.vue b/src/admin/src/components/segments/SegmentEditor.vue
index 55c5c70..621ffd6 100644
--- a/src/admin/src/components/segments/SegmentEditor.vue
+++ b/src/admin/src/components/segments/SegmentEditor.vue
@@ -140,7 +140,7 @@ watch(() => props.modelValue, (open) => {
 watch(() => props.segment, resetForm, { immediate: true });
 
 function onAddRuleGroup(): void {
-  form.value.rules = [...form.value.rules, { type: 'AND', conditions: [] }];
+  form.value.rules = [...form.value.rules, { type: 'All', conditions: [] }];
 }
 
 function onUpdateRule(index: number, rule: SegmentRule): void {
diff --git a/src/admin/src/types/api.ts b/src/admin/src/types/api.ts
index a3f5fdf..b5a09d0 100644
--- a/src/admin/src/types/api.ts
+++ b/src/admin/src/types/api.ts
@@ -234,7 +234,7 @@ export type SegmentConditionOperator =
   | 'PercentageSplit'
   | 'ModuloValueDivisorRemainder';
 
-export type SegmentRuleType = 'AND' | 'OR';
+export type SegmentRuleType = 'All' | 'Any';
 
 export interface SegmentCondition {
   id?: number;
diff --git a/src/admin/tests/unit/components/segments/SegmentEditor.spec.ts b/src/admin/tests/unit/components/segments/SegmentEditor.spec.ts
index ed673e9..962e460 100644
--- a/src/admin/tests/unit/components/segments/SegmentEditor.spec.ts
+++ b/src/admin/tests/unit/components/segments/SegmentEditor.spec.ts
@@ -24,7 +24,7 @@ const mockSegment: SegmentResponse = {
   name: 'beta_users',
   projectId: 10,
   createdAt: '2026-01-01T00:00:00Z',
-  rules: [{ type: 'AND', conditions: [{ property: 'plan', operator: 'Equal', value: 'beta' }] }],
+  rules: [{ type: 'All', conditions: [{ property: 'plan', operator: 'Equal', value: 'beta' }] }],
 };
 
 const dialogStub = { template: '<div><slot /></div>' };
diff --git a/src/admin/tests/unit/views/SegmentsView.spec.ts b/src/admin/tests/unit/views/SegmentsView.spec.ts
index 17bd1da..3ed7f34 100644
--- a/src/admin/tests/unit/views/SegmentsView.spec.ts
+++ b/src/admin/tests/unit/views/SegmentsView.spec.ts
@@ -24,7 +24,7 @@ const dialogStub = { template: '<div><slot /></div>' };
 const mockSegments: SegmentResponse[] = [
   {
     id: 1, name: 'beta_users', projectId: 10, createdAt: '2026-01-01T00:00:00Z',
-    rules: [{ type: 'AND', conditions: [{ property: 'plan', operator: 'Equal', value: 'beta' }] }],
+    rules: [{ type: 'All', conditions: [{ property: 'plan', operator: 'Equal', value: 'beta' }] }],
   },
   {
     id: 2, name: 'power_users', projectId: 10, createdAt: '2026-01-01T00:00:00Z',