wamplerj/mic-check
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Wait for the toggle PUT to land before reloading in the feature e2e test
Some checks failed
CI / build-and-push (push) Successful in 44s
Details
CI / deploy-qa (push) Successful in 11s
Details
CI / smoke-qa (push) Failing after 23s
Details

Browse Source 
The click fires an async toggle-state update; reloading immediately after
raced it and read back the pre-toggle value, flaking the persistence check.
This commit is contained in:
James Wampler
2026-07-04 18:42:10 -07:00
parent 37e00bf756
commit cfb6c5bde3
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/admin/e2e/features.e2e.ts
View File

@@ -32,6 +32,10 @@ test('creating a feature adds it to the table and its toggle can be flipped', as
await toggle.click({ force: true }); await toggle.click({ force: true });
await expect(toggle).toBeChecked({ checked: !wasChecked }); await expect(toggle).toBeChecked({ checked: !wasChecked });
// The click's own toggle-state PUT is async; wait for it to land before reloading,
// otherwise the reload can race it and read back the pre-toggle value.
await page.waitForLoadState('networkidle');
// Reload to confirm the toggle was persisted to the real API/DB, not just local state. // Reload to confirm the toggle was persisted to the real API/DB, not just local state.
await page.reload(); await page.reload();
const reloadedRow = page.getByRole('row', { name: new RegExp(featureName) }); const reloadedRow = page.getByRole('row', { name: new RegExp(featureName) });