Add unit tests for Environments, Audit, and Webhooks namespaces #6

wamplerj · 2026-07-05T15:03:14-07:00

wamplerj commented

2026-07-05 15:03:14 -07:00

Summary

Add missing unit test coverage for the Environments, Audit, and Webhooks namespaces (raises them from ~0-62% to 91-100%)
Exclude WebhookBackgroundService/WebhookRetryBackgroundService from coverage (require live DI/DB, disallowed by CLAUDE.md's no-InMemory/WebApplicationFactory rule)

Test plan

dotnet test full suite passes (646/646)
Coverage report confirms Environments ~99.5%, Audit 100%, Webhooks ~91%

## Summary - Add missing unit test coverage for the Environments, Audit, and Webhooks namespaces (raises them from ~0-62% to 91-100%) - Exclude WebhookBackgroundService/WebhookRetryBackgroundService from coverage (require live DI/DB, disallowed by CLAUDE.md's no-InMemory/WebApplicationFactory rule) ## Test plan - [x] `dotnet test` full suite passes (646/646) - [x] Coverage report confirms Environments ~99.5%, Audit 100%, Webhooks ~91%

wamplerj added 12 commits 2026-07-05 15:06:26 -07:00

Exclude Migrations namespace from dotnet code coverage 06e5359674

EF migrations are generated scaffolding with no meaningful logic to
test; counting them against the coverage target only dilutes the
signal.

Add unit tests for MicCheck.Api.Users 2759314f63

Covers UserService (profile update, email conflict, password change)
and UsersController (auth/validation/not-found/conflict branches),
raising the namespace from 3% coverage.

Add unit tests for MicCheck.Api.Segments b8ce405068

Covers CreateSegmentRequestValidator, response mapping (incl. nested
rules), SegmentsController, and gaps in SegmentService/SegmentEvaluator
(FindByIdAsync, not-found paths, nested rules, modulo/percentage edge
cases), raising the namespace from 66% to 98% coverage.

Compress CLAUDE.md into caveman-speak to cut context tokens b59c81f3b2

Original kept as CLAUDE.original.md for human reference.

Add unit tests for MicCheck.Api.Common, exclude untestable endpoint glue 611557ce81

ApiKeyService had zero coverage despite real logic (key generation,
hashing, org-scoped revoke). Also filled branch gaps in AuthService
(logout with unknown token) and the auth handlers (empty header
values).

ApiKeyEndpoints/AuthEndpoints are marked [ExcludeFromCodeCoverage]:
they're minimal-API route registration that needs a live HTTP
pipeline to exercise, which CLAUDE.md disallows (no
WebApplicationFactory/InMemory). Their branch logic is already
covered via the underlying service unit tests.

Raises the namespace from 66% to 91%. Remaining gap is plain
positional records with no logic (LoginRequest, PagedResult, etc.) -
left untested per CLAUDE.md's guidance against coverage-only tests.

Add unit tests for MicCheck.Api.Features 145e1f1be9

Covers validators, response mapping, TagService/TagsController,
FeaturesController (CRUD + tag assignment), FeatureSegmentService,
FeatureStateService (incl. webhook dispatch), and
FeatureUsageController. Fills gaps in FeatureService
(FindByIdAsync, not-found exceptions).

FeatureUsageFlushBackgroundService is marked [ExcludeFromCodeCoverage]:
timer-driven, issues raw SQL through a DI-scoped concrete DbContext,
can't be exercised cleanly without a live DB (CLAUDE.md disallows
WebApplicationFactory/InMemory).

Raises the namespace from 44% to 97%.

Exclude Data namespace from dotnet code coverage 7d4ab7991c

DbContext/EF configuration classes are infra plumbing with no
business logic to unit test; counting them against the coverage
target only dilutes the signal, same rationale as Migrations.

Add unit tests for MicCheck.Api.Identities 67d7de0362

Covers AdminIdentityService (list/create/find/upsert-trait/delete-trait/
delete/feature-state get-set-delete, all previously 0%), the
AdminIdentityResponse mapping, TraitInput's JSON/plain-type branch
logic, and IdentitiesController.GetByIdentifier.

Raises the namespace from 31% to 97.5%.

Add unit tests for MicCheck.Api.Organizations and MicCheck.Api.Projects 51539d24d8

Both namespaces had only entity tests. Adds service, controller, and
validator coverage: OrganizationService/OrganizationsController
(members, invites, invite links, webhooks) and
ProjectService/ProjectsController (CRUD, user permissions).

OrganizationService.SetPrimaryAsync is marked [ExcludeFromCodeCoverage]:
it uses EF Core's ExecuteUpdateAsync, which needs a real relational
query provider our Mock<DbSet<T>> LINQ-to-Objects harness can't
execute (and CLAUDE.md disallows EF InMemory as a substitute). Its
early-return branch is still covered.

Raises Organizations from 3.5% to 98.8% and Projects from 19.6% to
99.3%.

Reformat and tweaking claude.md 5b3050a222

Add unit tests for Environments namespace (0% to 99.5% coverage) 68d426253d

Covers EnvironmentService (CRUD, clone, list, find-by-key), the
EnvironmentsController orchestration layer (webhooks, audit logs,
identities/traits, feature states, feature segments, identity
segments), EnvironmentDocumentService/Controller, response mappers,
and request validators.

Add unit tests for Audit (59% to 100%) and Webhooks (62% to 91%) namespaces 9e8e81ba83

Covers AuditLogQueryService filtering/paging/actor-name join,
AuditLogResponse mapping, AuditLogsController, AuditService.LogAsync
and actor-claim resolution, WebhookResponse/WebhookDeliveryLogResponse
mapping, CreateWebhookRequestValidator, WebhookQueue, and additional
WebhookDispatcher branch coverage (scope routing, disabled webhooks,
delivery exceptions).

Excludes WebhookBackgroundService and WebhookRetryBackgroundService
from coverage: both resolve a DI-scoped concrete MicCheckDbContext via
IServiceScopeFactory, which requires a live DI container/DB per
CLAUDE.md's no-InMemory/WebApplicationFactory rule. Their query and
dispatch logic is covered by WebhookRetryTests/WebhookDispatcherTests.

wamplerj force-pushed add-missing-coverage-dotnet from 5959c1b2e3 to 9e8e81ba83

2026-07-05 15:06:26 -07:00

Compare

wamplerj merged commit 87113ccdcd into main

2026-07-05 15:07:27 -07:00

wamplerj deleted branch add-missing-coverage-dotnet

2026-07-05 15:07:27 -07:00

wamplerj referenced this issue from a commit

2026-07-05 15:07:27 -07:00

Add unit tests for Environments, Audit, and Webhooks namespaces (#6)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: wamplerj/mic-check#6