Remove FluentValidation; validator/DI cleanup #7

wamplerj · 2026-07-05T22:54:09-07:00

wamplerj commented

2026-07-05 22:54:09 -07:00

Summary

Remove FluentValidation dependency; replace with plain IModelValidator/ValidationResult pattern (ported from BuyEngine's Guard/validation approach), wired via a ModelValidationActionFilter
Move FeatureUsage code into MicCheck.Api.Features.Usage namespace
Convert logic-free data classes to records per CLAUDE.md (WebhookEvent, FeatureStateResult, ProjectPermissionRequirement, AuditLog, Tag, FeatureUsageDaily)
Extract IAuditService interface, drop virtual-method mock seam on AuditService
Split Program.cs DI registrations into per-namespace DependencyRegistration classes

Test plan

dotnet build (API + tests) clean
dotnet test MicCheck.Api.Tests.Unit — 646/646 passing
pre-push hook (full solution build/test + admin build) passed

## Summary - Remove FluentValidation dependency; replace with plain IModelValidator<T>/ValidationResult pattern (ported from BuyEngine's Guard/validation approach), wired via a ModelValidationActionFilter - Move FeatureUsage code into MicCheck.Api.Features.Usage namespace - Convert logic-free data classes to records per CLAUDE.md (WebhookEvent, FeatureStateResult, ProjectPermissionRequirement, AuditLog, Tag, FeatureUsageDaily) - Extract IAuditService interface, drop virtual-method mock seam on AuditService - Split Program.cs DI registrations into per-namespace DependencyRegistration classes ## Test plan - [x] dotnet build (API + tests) clean - [x] dotnet test MicCheck.Api.Tests.Unit — 646/646 passing - [x] pre-push hook (full solution build/test + admin build) passed

wamplerj added 5 commits 2026-07-05 22:54:09 -07:00

Remove FluentValidation dependency, use plain .NET validation bdc85a1f3a

Replace AbstractValidator-based request validators with a small
IModelValidator<T>/ValidationResult pattern (ported from BuyEngine's
Common namespace), wired into the MVC pipeline via a
ModelValidationActionFilter so controllers and response shape are
unaffected. Also copy over the Guard precondition helper.

Move FeatureUsage code into MicCheck.Api.Features.Usage namespace 27497e31a9

Groups usage-tracking (metrics, background flush, query service,
controller, entity) under its own namespace/folder, updates all
consumers and the EF migration snapshot's CLR type strings to match.

Convert logic-free classes to records per CLAUDE.md 75595970fb

WebhookEvent, FeatureStateResult, ProjectPermissionRequirement, AuditLog,
Tag, and FeatureUsageDaily are plain data holders with no behavior, so
switch them to records. EF-mapped entities with identity semantics
(User, Organization, Project, Feature, Segment, etc.) stay classes,
since record value-equality and deep ToString fight EF's change tracker.

Also restore `virtual` on AuditService.RecordAsync/LogAsync, which had
been dropped and broke Mock<AuditService>-based test setups.

Extract IAuditService, drop virtual mock seam from AuditService f920a6d0a5

Consumers now depend on IAuditService instead of the concrete class,
so tests mock the interface (Mock<IAuditService>()) rather than
subclassing AuditService via virtual methods.

Split Program.cs DI registrations into per-namespace DependencyRegistration classes

CI / build-and-push (push) Successful in 45s

Details

CI / deploy-qa (push) Has been skipped

Details

CI / smoke-qa (push) Has been skipped

Details

7b51100ab6

Each root namespace (Audit, Common, Data, Environments, Features/Usage,
Identities, Organizations, Projects, Segments, Users, Webhooks) gets its
own static DependencyRegistration class exposing an Add<Name>Services
extension method, so Program.cs just wires them together instead of
listing every registration inline.

gitea-actions bot added 1 commit 2026-07-05 22:54:22 -07:00

chore: refresh coverage badge [skip ci] d4feca8ad4

wamplerj merged commit 7a3e2167c2 into main

2026-07-05 22:54:31 -07:00

wamplerj deleted branch fluent-validator-gone

2026-07-05 22:54:31 -07:00

wamplerj referenced this issue from a commit

2026-07-05 22:54:31 -07:00

Remove FluentValidation; validator/DI cleanup (#7)

Sign in to join this conversation.