## Summary - Extract `IMicCheckDbContext` and mock DB access with Moq instead of the EF InMemory provider, per CLAUDE.md testing guidelines. - Rewrite HTTP-pipeline tests to exercise controllers/auth handlers directly instead of `WebApplicationFactory`. - Remove tuple return types across the API in favor of named records (`PagedResult<T>`, `ProfileUpdateResult`, `ApiKeyCreationResult`). ## Test plan - [x] `dotnet build` (full solution) - [x] `dotnet test tests/api/MicCheck.Api.Tests.Unit` — 187/187 pass - [x] `dotnet test tests/api/MicCheck.Api.Tests.Integration` — 8/8 pass (live API + Postgres via Aspire) - [x] Verified Aspire AppHost/dashboard starts and API responds Reviewed-on: #4
114 lines
4.0 KiB
C#
Executable File
114 lines
4.0 KiB
C#
Executable File
using System.Text.Json;
|
|
using MicCheck.Api.Audit;
|
|
using MicCheck.Api.Data;
|
|
using MicCheck.Api.Tests.Unit.TestSupport;
|
|
using MicCheck.Api.Webhooks;
|
|
using Microsoft.AspNetCore.Http;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
|
|
namespace MicCheck.Api.Tests.Unit.Audit;
|
|
|
|
[TestFixture]
|
|
public class AuditServiceTests
|
|
{
|
|
private Mock<IMicCheckDbContext> _db = null!;
|
|
private List<AuditLog> _auditLogs = null!;
|
|
private AuditService _service = null!;
|
|
private WebhookQueue _queue = null!;
|
|
|
|
[SetUp]
|
|
public void SetUp()
|
|
{
|
|
_db = new Mock<IMicCheckDbContext>();
|
|
_auditLogs = [];
|
|
_db.SetupDbSet(c => c.AuditLogs, _auditLogs);
|
|
_queue = new WebhookQueue();
|
|
|
|
var httpContextAccessor = new Mock<IHttpContextAccessor>();
|
|
httpContextAccessor.Setup(x => x.HttpContext).Returns((HttpContext?)null);
|
|
|
|
_service = new AuditService(_db.Object, httpContextAccessor.Object, _queue);
|
|
}
|
|
|
|
[Test]
|
|
public async Task WhenRecordingWithNoBefore_ThenChangesIsNull()
|
|
{
|
|
await _service.RecordAsync("Feature", "1", "created", organizationId: 1);
|
|
|
|
var log = _auditLogs.First();
|
|
Assert.That(log.Changes, Is.Null);
|
|
}
|
|
|
|
[Test]
|
|
public async Task WhenRecordingWithAfterOnly_ThenChangesContainsAfterJson()
|
|
{
|
|
var after = new { Name = "dark_mode", Enabled = true };
|
|
await _service.RecordAsync("Feature", "1", "created", organizationId: 1, after: after);
|
|
|
|
var log = _auditLogs.First();
|
|
Assert.That(log.Changes, Is.Not.Null);
|
|
|
|
var changes = JsonDocument.Parse(log.Changes!).RootElement;
|
|
Assert.That(changes.GetProperty("after").GetProperty("name").GetString(), Is.EqualTo("dark_mode"));
|
|
Assert.That(changes.TryGetProperty("before", out var beforeProp), Is.True);
|
|
Assert.That(beforeProp.ValueKind, Is.EqualTo(JsonValueKind.Null));
|
|
}
|
|
|
|
[Test]
|
|
public async Task WhenRecordingWithBeforeAndAfter_ThenChangesCapturesBothStates()
|
|
{
|
|
var before = new { Enabled = false, Value = "old" };
|
|
var after = new { Enabled = true, Value = "new" };
|
|
|
|
await _service.RecordAsync("FeatureState", "42", "updated", organizationId: 1,
|
|
before: before, after: after);
|
|
|
|
var log = _auditLogs.First();
|
|
var changes = JsonDocument.Parse(log.Changes!).RootElement;
|
|
|
|
Assert.That(changes.GetProperty("before").GetProperty("enabled").GetBoolean(), Is.False);
|
|
Assert.That(changes.GetProperty("after").GetProperty("enabled").GetBoolean(), Is.True);
|
|
Assert.That(changes.GetProperty("before").GetProperty("value").GetString(), Is.EqualTo("old"));
|
|
Assert.That(changes.GetProperty("after").GetProperty("value").GetString(), Is.EqualTo("new"));
|
|
}
|
|
|
|
[Test]
|
|
public async Task WhenRecording_ThenMetadataIsPersistedCorrectly()
|
|
{
|
|
await _service.RecordAsync(
|
|
"Segment", "5", "deleted",
|
|
organizationId: 10, projectId: 20, environmentId: 30);
|
|
|
|
var log = _auditLogs.First();
|
|
Assert.That(log.ResourceType, Is.EqualTo("Segment"));
|
|
Assert.That(log.ResourceId, Is.EqualTo("5"));
|
|
Assert.That(log.Action, Is.EqualTo("deleted"));
|
|
Assert.That(log.OrganizationId, Is.EqualTo(10));
|
|
Assert.That(log.ProjectId, Is.EqualTo(20));
|
|
Assert.That(log.EnvironmentId, Is.EqualTo(30));
|
|
Assert.That(log.ActorUserId, Is.Null);
|
|
}
|
|
|
|
[Test]
|
|
public async Task WhenRecording_ThenAuditLogCreatedEventIsEnqueued()
|
|
{
|
|
await _service.RecordAsync("Feature", "1", "created", organizationId: 1);
|
|
|
|
var events = new List<WebhookEvent>();
|
|
var cts = new CancellationTokenSource(TimeSpan.FromMilliseconds(100));
|
|
try
|
|
{
|
|
await foreach (var e in _queue.ReadAllAsync(cts.Token))
|
|
{
|
|
events.Add(e);
|
|
break;
|
|
}
|
|
}
|
|
catch (OperationCanceledException) { }
|
|
|
|
Assert.That(events, Has.Count.EqualTo(1));
|
|
Assert.That(events[0].EventType, Is.EqualTo(WebhookEventTypes.AuditLogCreated));
|
|
}
|
|
}
|