James Wampler
20188c61a2
## Summary - Extract `IMicCheckDbContext` and mock DB access with Moq instead of the EF InMemory provider, per CLAUDE.md testing guidelines. - Rewrite HTTP-pipeline tests to exercise controllers/auth handlers directly instead of `WebApplicationFactory`. - Remove tuple return types across the API in favor of named records (`PagedResult<T>`, `ProfileUpdateResult`, `ApiKeyCreationResult`). ## Test plan - [x] `dotnet build` (full solution) - [x] `dotnet test tests/api/MicCheck.Api.Tests.Unit` — 187/187 pass - [x] `dotnet test tests/api/MicCheck.Api.Tests.Integration` — 8/8 pass (live API + Postgres via Aspire) - [x] Verified Aspire AppHost/dashboard starts and API responds Reviewed-on: #4
70 lines
2.8 KiB
C#
Executable File
70 lines
2.8 KiB
C#
Executable File
using MicCheck.Api.Common;
|
|
using MicCheck.Api.Data;
|
|
using Microsoft.EntityFrameworkCore;
|
|
|
|
namespace MicCheck.Api.Audit;
|
|
|
|
public class AuditLogQueryService(IMicCheckDbContext db)
|
|
{
|
|
public async Task<PagedResult<AuditLogResponse>> ListByOrganizationAsync(
|
|
int organizationId, AuditLogFilter filter, CancellationToken ct = default)
|
|
{
|
|
var query = db.AuditLogs.Where(l => l.OrganizationId == organizationId);
|
|
return await ApplyFilterAndPageAsync(query, filter, ct);
|
|
}
|
|
|
|
public async Task<PagedResult<AuditLogResponse>> ListByProjectAsync(
|
|
int projectId, AuditLogFilter filter, CancellationToken ct = default)
|
|
{
|
|
var query = db.AuditLogs.Where(l => l.ProjectId == projectId);
|
|
return await ApplyFilterAndPageAsync(query, filter, ct);
|
|
}
|
|
|
|
public async Task<PagedResult<AuditLogResponse>> ListByEnvironmentAsync(
|
|
int environmentId, AuditLogFilter filter, CancellationToken ct = default)
|
|
{
|
|
var query = db.AuditLogs.Where(l => l.EnvironmentId == environmentId);
|
|
return await ApplyFilterAndPageAsync(query, filter, ct);
|
|
}
|
|
|
|
private async Task<PagedResult<AuditLogResponse>> ApplyFilterAndPageAsync(
|
|
IQueryable<AuditLog> query, AuditLogFilter filter, CancellationToken ct)
|
|
{
|
|
if (filter.From.HasValue)
|
|
query = query.Where(l => l.CreatedAt >= filter.From.Value);
|
|
if (filter.To.HasValue)
|
|
query = query.Where(l => l.CreatedAt <= filter.To.Value);
|
|
if (!string.IsNullOrEmpty(filter.ResourceType))
|
|
query = query.Where(l => l.ResourceType == filter.ResourceType);
|
|
if (!string.IsNullOrEmpty(filter.Action))
|
|
query = query.Where(l => l.Action == filter.Action);
|
|
if (filter.ProjectId.HasValue)
|
|
query = query.Where(l => l.ProjectId == filter.ProjectId);
|
|
if (filter.EnvironmentId.HasValue)
|
|
query = query.Where(l => l.EnvironmentId == filter.EnvironmentId);
|
|
if (filter.ActorUserId.HasValue)
|
|
query = query.Where(l => l.ActorUserId == filter.ActorUserId);
|
|
|
|
var total = await query.CountAsync(ct);
|
|
var pageSize = Math.Clamp(filter.PageSize, 1, 100);
|
|
|
|
var items = await query
|
|
.OrderByDescending(l => l.CreatedAt)
|
|
.Skip((filter.Page - 1) * pageSize)
|
|
.Take(pageSize)
|
|
.GroupJoin(
|
|
db.Users,
|
|
log => log.ActorUserId,
|
|
user => (int?)user.Id,
|
|
(log, users) => new { log, users })
|
|
.SelectMany(
|
|
x => x.users.DefaultIfEmpty(),
|
|
(x, user) => AuditLogResponse.From(
|
|
x.log,
|
|
user != null ? user.FirstName + " " + user.LastName : null))
|
|
.ToListAsync(ct);
|
|
|
|
return new PagedResult<AuditLogResponse>(total, items);
|
|
}
|
|
}
|